Skip to content

Bug 2032926: feat: library-go bump and leader election config#155

Merged
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
eggfoobar:library_go_bump
Dec 21, 2021
Merged

Bug 2032926: feat: library-go bump and leader election config#155
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

  • updated to latest library-go
  • updated start commands to use leaderelection configs from library-go
  • updated controller-runtime to k8s 0.23.0 support
  • fixed test for new logr interface

Signed-off-by: ehila ehila@redhat.com

@openshift-ci openshift-ci Bot requested review from Fedosin and elmiko December 15, 2021 17:48
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Dec 15, 2021

Currently blocked by openshift/release#24668

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Dec 15, 2021

/retest

@damdo
Copy link
Copy Markdown
Member

damdo commented Dec 16, 2021

/test unit

@JoelSpeed
Copy link
Copy Markdown
Contributor

/retest-required
/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@damdo
Copy link
Copy Markdown
Member

damdo commented Dec 20, 2021

Depends on #154

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Dec 20, 2021

/test unit

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Dec 20, 2021

/test unit

updated to latest library-go
updated controller-runtime to k8s 0.23.0 support
updated testingutils pkg to use new logr interface change

Signed-off-by: ehila <ehila@redhat.com>
updated leader election to use library-go defaults
removed durations.go and replaced with leaderelection.go for clarity

Signed-off-by: ehila <ehila@redhat.com>
removed unused emptylogger struct
updated toggle for turning on and off klog logging

Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
updated to latest library-go
added rbac kubebuilder comment

Signed-off-by: ehila <ehila@redhat.com>
@damdo
Copy link
Copy Markdown
Member

damdo commented Dec 21, 2021

/retest-required

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Dec 21, 2021

/retitle Bug 2032926: feat: library-go bump and leader election config

@openshift-ci openshift-ci Bot changed the title feat: library-go bump and leader election config Bug 2032926: feat: library-go bump and leader election config Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@eggfoobar: This pull request references Bugzilla bug 2032926, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 2032926: feat: library-go bump and leader election config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2021
@openshift-ci openshift-ci Bot requested a review from sunzhaohua2 December 21, 2021 08:49
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@damdo
Copy link
Copy Markdown
Member

damdo commented Dec 21, 2021

/retest-required

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure e7c2f14 link false /test e2e-azure
ci/prow/e2e-azure-ccm-install e7c2f14 link false /test e2e-azure-ccm-install
ci/prow/e2e-gcp-ccm e7c2f14 link false /test e2e-gcp-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d24d3c5 into openshift:master Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@eggfoobar: All pull requests linked via external trackers have merged:

Bugzilla bug 2032926 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2032926: feat: library-go bump and leader election config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants